-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit 'shutdown' outside -[NSApplication terminate:] #24111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Jun 15, 2020
deepak1556
approved these changes
Jun 15, 2020
Release Notes Persisted
|
This was referenced Jun 16, 2020
I have automatically backported this PR to "10-x-y", please check out #24139 |
I have automatically backported this PR to "8-x-y", please check out #24140 |
I have automatically backported this PR to "9-x-y", please check out #24141 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #24105.
When macOS shuts down, Cocoa will send an
NSWorkspaceWillPowerOffNotification
followed by-[NSApplication terminate:]
. The original PR that added this on macOS hooked into the latter instead of the former, thereby creating the side effect that it would also be called when the app itself terminated.For more effective dx, this PR registers for
NSWorkspaceWillPowerOffNotification
and then emits'shutdown'
when the notification is sent instead.cc @zcbenz @deepak1556 @nornagon
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
shutdown
would be emitted both on app and system shutdown on macOS.