Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add worldSafe flag for executeJS results #24711

Merged
merged 12 commits into from Aug 5, 2020
Merged

feat: add worldSafe flag for executeJS results #24711

merged 12 commits into from Aug 5, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 23, 2020

Backport of #24114

See that PR for details.

Notes: Added new worldSafeExecuteJavaScript webPreference to ensure that the return values from webFrame.executeJavaScript are world safe when context isolation is enabled

@trop trop bot requested a review from MarshallOfSound July 23, 2020 21:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 23, 2020
@trop trop bot mentioned this pull request Jul 23, 2020
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2020
codebytere
codebytere approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Release WG

@MarshallOfSound MarshallOfSound merged commit bc48847 into 10-x-y Aug 5, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 5, 2020

Release Notes Persisted

Added new worldSafeExecuteJavaScript webPreference to ensure that the return values from webFrame.executeJavaScript are world safe when context isolation is enabled

@codebytere codebytere deleted the trop/10-x-y-bp-feat-add-worldsafe-flag-for-executejs-results-1595539955916 branch August 5, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport/approved ✅ backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound