test: add a test for BaseWindow.hookWindowMessage #24761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Jul 28, 2020
deepak1556
previously approved these changes
Jul 28, 2020
|
@deepak1556 un-wip now, tests should be more complete. |
|
Hm, I'm surprised that these tests are passing, given #24716 has not yet merged. |
deepak1556
force-pushed
the
hookmessage-test
branch
from
aca80e5
to
30b01b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There was no test for this and it broke.
Checklist
npm testpassesRelease Notes
Notes: none