Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when navigating from a page with webview that has inherited zoom level #24763

Merged
merged 4 commits into from
Jul 29, 2020
Merged

fix: crash when navigating from a page with webview that has inherited zoom level #24763

merged 4 commits into from
Jul 29, 2020

Commits on Jul 28, 2020

  1. fix: cleanup webview zoom level observers on navigation

    @deepak1556 @electron-bot
    deepak1556 authored and electron-bot committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b2fc74d View commit details
    Browse the repository at this point in the history

  2. add spec

    @deepak1556 @electron-bot
    deepak1556 authored and electron-bot committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f2ca431 View commit details
    Browse the repository at this point in the history

  3. webview should be on same partition

    @deepak1556 @electron-bot
    deepak1556 authored and electron-bot committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    ea38fb5 View commit details
    Browse the repository at this point in the history

  4. wait for webview to finish loading

    @deepak1556 @electron-bot
    deepak1556 authored and electron-bot committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    a358f1c View commit details
    Browse the repository at this point in the history