Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap OnWindowMessage w/ handlescope #24769

Merged
merged 2 commits into from Jul 29, 2020
Merged

fix: wrap OnWindowMessage w/ handlescope #24769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c099de0
fix: wrap OnWindowMessage w/ handlescope (#24716)
nornagon Jul 28, 2020
ce8d4d5
Update electron_api_top_level_window.cc
nornagon Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions shell/browser/api/electron_api_top_level_window.cc
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@
#include "shell/browser/api/electron_api_menu.h"
#include "shell/browser/api/electron_api_view.h"
#include "shell/browser/api/electron_api_web_contents.h"
#include "shell/browser/javascript_environment.h"
#include "shell/common/color_util.h"
#include "shell/common/gin_converters/callback_converter.h"
#include "shell/common/gin_converters/file_path_converter.h"
Expand Down Expand Up @@ -290,6 +291,8 @@ void TopLevelWindow::OnWindowMessage(UINT message,
WPARAM w_param,
LPARAM l_param) {
if (IsWindowMessageHooked(message)) {
v8::Locker locker(isolate());
v8::HandleScope scope(isolate());
messages_callback_map_[message].Run(
ToBuffer(isolate(), static_cast<void*>(&w_param), sizeof(WPARAM)),
ToBuffer(isolate(), static_cast<void*>(&l_param), sizeof(LPARAM)));
Expand Down