New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sync devtools frontend mime types with upstream #25780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
codebytere
approved these changes
Oct 6, 2020
think you're missing a header:
|
whups, fixed locally and forgot to push. |
Release Notes Persisted
|
/trop run backport |
The backport process for this PR has been manually initiated, here we go! :D |
I have automatically backported this PR to "11-x-y", please check out #27102 |
imran1008
pushed a commit
to bloomberg/chromium.bb
that referenced
this pull request
Dec 22, 2021
Electron had similar issue in its devtools: electron/electron#27103. Electron fixed the issue by adapting changes from Chromium upstream: electron/electron#25780. This PR also adapted upstream changes for adding more mime types support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #25778.
This updates the function to match
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/webui/devtools_ui_data_source.cc;l=52;drc=2de0b2cfe26853bda417346c8a6e6538a06780d8.
Checklist
npm test
passesRelease Notes
Notes: Fixed the pretty-print JavaScript feature in DevTools not functioning correctly.