-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when loading wasm in mac arm64 #26313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepak1556 in my work of getting CI testing working on a DTK, I found that this patch is not needed at all: #24832
@jkleinsc that would be ideal, is there a timeline for when the native compiled arm64 releases will be available ? The current cross compiled build is a no-go for vscode because of this wasm crash. Also while testing this fix realized that v8 made most of its fixes using |
@deepak1556 native arm64 releases are currently available for 11-x-y betas as well as on our nightly builds. |
Isn't it cross-compiled https://github.com/electron/electron/blob/master/.circleci/config.yml#L141 ? |
@deepak1556 ah --I missed the cross-compiled bit of your comment. Yes we cross-compile the arm64 binary on x64. We won't have a native compiled arm64 release until our CircleCI provides arm64 macs and as of right now I don't have a date for that. |
@MarshallOfSound @jkleinsc can we remove the following patches from 11-x-y branch ? chrome arm64 beta (87.0.4280.67) is available without these, so I don't think we need them either ? https://github.com/electron/electron/blob/11-x-y/patches/v8/chore_add_v8_apple_silicon_patches.patch |
@deepak1556 yes -- I'll put up a PR for that. #24832 is waiting until I have enough macs to run arm64 CI, but we can just address 11-x-y for now. |
@deepak1556 PR is up here: #26650 |
Description of Change
Instead of defaulting to always write protect, prefer v8 fix that does write and executable protection hop using background thread https://chromium-review.googlesource.com/c/v8/v8/+/2378307 .
Test: https://gist.github.com/deepak1556/c85a324822bf64ffeef450f3d1f33119
Refs microsoft/vscode#106770 (comment)
Checklist
npm test
passesRelease Notes
Notes: fix crash when loading wasm in mac arm64