fix: stack traces in non-Node.js contexts #26820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-error-stack-renderer
branch
from
e5744b7
to
3815472
Compare
MarshallOfSound
added
semver/patch
codebytere
force-pushed
the
fix-error-stack-renderer
branch
from
3815472
to
2defa24
Compare
2 tasks
nornagon
approved these changes
Dec 8, 2020
deepak1556
reviewed
Dec 8, 2020
codebytere
force-pushed
the
fix-error-stack-renderer
branch
from
2defa24
to
b7c33f1
Compare
jkleinsc
approved these changes
Dec 9, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "11-x-y" cleanly; |
|
I have automatically backported this PR to "12-x-y", please check out #26912 |
|
@codebytere has manually backported this PR to "11-x-y", please check out #26997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #26677.
Node.js sets a stack trace handler specific to the context corresponding to the current
Environment. When we're running in a non-Node.js context, there will be no correspondentEnvironment- we therefore need to unset this handler so that Blink falls back to its default handling and displays the correct stacktrace.Upstreamed at nodejs/node#36447.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where renderer process stack traces were broken with
contextIsolationenabled.