Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: screen EventEmitter methods with remote #26988

Merged
merged 1 commit into from
Dec 14, 2020
Merged

fix: screen EventEmitter methods with remote #26988

merged 1 commit into from
Dec 14, 2020

Conversation

codebytere
Copy link
Member

Backport of #26809.

See that PR for details.

Notes: Fixed an issue whereby remote.screen EventEmitter methods are undefined in the renderer.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 14, 2020
@trop trop bot mentioned this pull request Dec 14, 2020
Merged
3 tasks
@trop trop bot added 12-x-y backport This is a backport PR labels Dec 14, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 14, 2020
@codebytere codebytere requested a review from a team December 14, 2020 16:20
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Dec 14, 2020
@codebytere
Copy link
Member Author

Error is not related.

@codebytere codebytere merged commit d2c4b59 into 12-x-y Dec 14, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 14, 2020

Release Notes Persisted

Fixed an issue whereby remote.screen EventEmitter methods are undefined in the renderer.

@codebytere codebytere deleted the eventemitter-remote-12 branch December 14, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound