fix: handle BrowserView reparenting #27000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Dec 14, 2020
deepak1556
reviewed
Dec 14, 2020
codebytere
force-pushed
the
bv-reparenting-handle
branch
from
1d4dd84
to
e4c386b
Compare
5 tasks
codebytere
force-pushed
the
bv-reparenting-handle
branch
from
e4c386b
to
a89cf08
Compare
MarshallOfSound
approved these changes
Jan 4, 2021
|
Release Notes Persisted
|
|
I was unable to backport this PR to "11-x-y" cleanly; |
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I have automatically backported this PR to "12-x-y", please check out #27187 |
|
@codebytere has manually backported this PR to "11-x-y", please check out #27219 |
|
@codebytere has manually backported this PR to "10-x-y", please check out #27220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #26975.
Fixes an issue where a
BrowserViewcouldn't be reparented properly (moved from oneBrowserWindowto another) because it wasn't properly detached from the firstBrowserWindow.A
BrowserWindowhas a one-to-many relationship withBrowserViews, but aBrowserViewcan only have a single owner window. As such, if aBrowserViewis added to aBrowserWindowwhich has an owner window which is both not null and not the current window in question, then it needs to be properly detached from the previous owner window.Tested with https://gist.github.com/a786242649a5d2e462c3328c905f0c9f.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where BrowserViews couldn't be effectively reparented.