Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add win.setTopBrowserView() so that BrowserViews can be raised #27007

Merged
merged 13 commits into from Feb 10, 2021
Merged

feat: add win.setTopBrowserView() so that BrowserViews can be raised #27007

merged 13 commits into from Feb 10, 2021

Commits on Dec 8, 2020

  1. feat: Raise a browser view via BrowserWindow.setTopBrowserView(). 

    This is similar to removing and re-adding a browser view, but avoids a visible flicker as the browser view is not removed from the window when using `setTopBrowserView`. Note: if the given browser view is not attached to the window, it will be added.

This commit contains the macOS implementation.
    @stewartlord
    stewartlord committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    3a21895 View commit details
    Browse the repository at this point in the history

  2. feat: setTopBrowserView support for Windows and Linux

    @sentialx @stewartlord
    sentialx authored and stewartlord committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    0c580f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. docs: add info about setTopBrowserView

    @sentialx
    sentialx committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a5b67de View commit details
    Browse the repository at this point in the history

  2. docs: Clarify behavior when browserView is not yet attached.

    @stewartlord
    stewartlord committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    5c61f6d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. fix: throw en error when browserView is not attached to the window

    @sentialx
    sentialx committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    8c50d31 View commit details
    Browse the repository at this point in the history

  2. fix: build error

    @sentialx
    sentialx committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    3cb302b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. fix: test

    @sentialx
    sentialx committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a86521d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. fix: add test case

    @sentialx
    sentialx committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    caf417d View commit details
    Browse the repository at this point in the history

  2. fix: tests

    @sentialx
    sentialx committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    496cacf View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Merge remote-tracking branch 'upstream/master' into set-top-browser-view

    @sentialx
    sentialx committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f70753b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. fix: reparenting

    @sentialx
    sentialx committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    00889c0 View commit details
    Browse the repository at this point in the history

  2. fix: close second window in tests

    @sentialx
    sentialx committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    17766c7 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Merge remote-tracking branch 'upstream/master' into set-top-browser-view

    @sentialx
    sentialx committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    60a4aff View commit details
    Browse the repository at this point in the history