Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make webContents.id work even after destroy #27038

Merged
merged 1 commit into from Dec 17, 2020
Merged

fix: make webContents.id work even after destroy #27038

merged 1 commit into from Dec 17, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Fixes #26567.

This makes WebContents.id work even after the underlying WebContents C++
object is destroyed, allowing remote to clean up its object registry safely.

Checklist

Release Notes

Notes: Fixed a crash that could occur on app quit when using the remote module.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2020
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/11-x-y labels Dec 16, 2020
@codebytere
Copy link
Member

Can we add a test?

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 17, 2020
@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Dec 17, 2020
@MarshallOfSound
Copy link
Member

@codebytere this is actually quite bad, going to fast track this one in and we can follow up with a test retroactively. I hit this with the most basic fiddles all the time.

@MarshallOfSound MarshallOfSound merged commit da3d21e into master Dec 17, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 17, 2020

Release Notes Persisted

Fixed a crash that could occur on app quit when using the remote module.

@MarshallOfSound MarshallOfSound deleted the webcontents-id-after-destroy branch December 17, 2020 20:10
This was referenced Dec 17, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Dec 17, 2020

I have automatically backported this PR to "11-x-y", please check out #27069

@trop
Copy link
Contributor

trop bot commented Dec 17, 2020

I have automatically backported this PR to "12-x-y", please check out #27070

@pushkin- pushkin- mentioned this pull request Dec 18, 2020
Merged
@miniak miniak mentioned this pull request May 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app throws exception on quit() function in electron version 11
4 participants
@nornagon @codebytere @MarshallOfSound @miniak