Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make protocol wrapper remote-friendly again #27043

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 16, 2020

Backport of #27009

See that PR for details.

Notes: Fixed protocol methods not being accessible via remote.protocol.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2020
@trop trop bot requested a review from zcbenz December 16, 2020 07:57
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2020
@codebytere
Copy link
Member

Failure:

tag did-change-theme-color event emits when theme color changes

is not related.

@codebytere codebytere merged commit 39f865e into 12-x-y Dec 16, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 16, 2020

Release Notes Persisted

Fixed protocol methods not being accessible via remote.protocol.

@codebytere codebytere deleted the trop/12-x-y-bp-fix-make-protocol-wrapper-remote-friendly-again-1608105460460 branch December 16, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants