Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unclickable regions in some draggable BrowserViews #27143

Merged
merged 1 commit into from Jan 4, 2021

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Dec 29, 2020

Description of Change

Closes #27131.
Closes #27149.

Fixes an issue where some BrowserViews might exhibit unclickable button behavior when loading some websites. What was happening was that #26738 made the mistaken assumption that snapped areas should be draggable, which meant that when users set -webkit-app-region: no-drag the areas would become draggable (and thus not clickable).

Tested with https://gist.github.com/f1426205af6799b5d208d1cd54136457 and confirmed not to regress initial fix made in #26738 with https://gist.github.com/7278c8c62ec976110afb47ef2d861a7a.

Checklist

Release Notes

Notes: Fixed an issue where some draggable regions were not clickable when loaded into BrowserViews on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 29, 2020
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Dec 29, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 30, 2020
@codebytere codebytere merged commit 29c2e2c into master Jan 4, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2021

Release Notes Persisted

Fixed an issue where some draggable regions were not clickable when loaded into BrowserViews on Windows.

@codebytere codebytere deleted the draggable-fix-no-drag branch January 4, 2021 19:22
@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I have automatically backported this PR to "12-x-y", please check out #27177

@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I have automatically backported this PR to "11-x-y", please check out #27178

@quanglam2807
Copy link
Contributor

Thank you so much, @codebytere!

My app relied quite a lot on BrowserView so this bug is critical. Is it possible to cut a release with this patch this week?

@trop
Copy link
Contributor

trop bot commented Jan 7, 2021

@codebytere has manually backported this PR to "10-x-y", please check out #27222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
3 participants