New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unclickable regions in some draggable BrowserViews #27143
Conversation
Release Notes Persisted
|
I was unable to backport this PR to "10-x-y" cleanly; |
I have automatically backported this PR to "12-x-y", please check out #27177 |
I have automatically backported this PR to "11-x-y", please check out #27178 |
Thank you so much, @codebytere! My app relied quite a lot on |
@codebytere has manually backported this PR to "10-x-y", please check out #27222 |
Description of Change
Closes #27131.
Closes #27149.
Fixes an issue where some BrowserViews might exhibit unclickable button behavior when loading some websites. What was happening was that #26738 made the mistaken assumption that snapped areas should be draggable, which meant that when users set
-webkit-app-region: no-drag
the areas would become draggable (and thus not clickable).Tested with https://gist.github.com/f1426205af6799b5d208d1cd54136457 and confirmed not to regress initial fix made in #26738 with https://gist.github.com/7278c8c62ec976110afb47ef2d861a7a.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where some draggable regions were not clickable when loaded into BrowserViews on Windows.