Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f9add3b8e5 from chromium. #27443

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jan 21, 2021

MediaCapabilities: Use threadsafe static wtf::String

This replaces DEFINE_THREAD_SAFE_STATIC_LOCAL(const String, ...).
StringImpl ref counting (behind that macro) is not currently threadsafe.

(cherry picked from commit f9add3b8e53c440129f7be4a181a22c440e856bc)

Bug: 1160534
Change-Id: I70f4aa796aaefabbee36db4fcdf0fbf0defe4959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606399
Commit-Queue: Chrome Cunningham chcunningham@chromium.org
Reviewed-by: Jeremy Roman jbroman@chromium.org
Auto-Submit: Chrome Cunningham chcunningham@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#839863}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611646
Reviewed-by: Chrome Cunningham chcunningham@chromium.org
Cr-Commit-Position: refs/branch-heads/4324@{#1460}
Cr-Branched-From: c73b5a651d37a6c4d0b8e3262cc4015a5579c6c8-refs/heads/master@{#827102}

Release Notes

Notes: backported the fix to chromium:1160534.

@ppontes ppontes added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 11-x-y labels Jan 21, 2021
@ppontes ppontes requested a review from a team as a code owner January 21, 2021 21:36
@ppontes ppontes force-pushed the cherry-pick/11-x-y/chromium/f9add3b8e5 branch from 244ad87 to edf8104 Compare January 21, 2021 21:37
@ppontes ppontes changed the title chore: cherry-pick f9add3b8e5 from chromium. [wip] chore: cherry-pick f9add3b8e5 from chromium. Jan 21, 2021
@ppontes ppontes added wip ⚒ and removed wip ⚒ labels Jan 21, 2021
@ppontes ppontes changed the title [wip] chore: cherry-pick f9add3b8e5 from chromium. chore: cherry-pick f9add3b8e5 from chromium. Jan 22, 2021
@ppontes ppontes force-pushed the cherry-pick/11-x-y/chromium/f9add3b8e5 branch from edf8104 to c2eae24 Compare January 22, 2021 15:10
@deepak1556 deepak1556 merged commit 47adc0a into 11-x-y Jan 22, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2021

Release Notes Persisted

backported the fix to chromium:1160534.

@deepak1556 deepak1556 deleted the cherry-pick/11-x-y/chromium/f9add3b8e5 branch January 22, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants