fix: crash when loadExtension fails #27561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Feb 1, 2021
miniak
approved these changes
Feb 2, 2021
zcbenz
approved these changes
Feb 2, 2021
|
Release Notes Persisted
|
This was referenced Feb 2, 2021
|
I have automatically backported this PR to "11-x-y", please check out #27588 |
|
I have automatically backported this PR to "12-x-y", please check out #27589 |
|
I have automatically backported this PR to "10-x-y", please check out #27590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A segfault occurs when an extension fails to load.
I forgot to check for a nullptr before writing an extension pref in #22655
Checklist
npm testpassesRelease Notes
Notes: Fixed crash when extension fails to load.