Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed src="about:blank" from devtool #27835

Closed
wants to merge 1 commit into from

Conversation

errorr404
Copy link

@errorr404 errorr404 commented Feb 20, 2021

with src="about:blank" in webview for devtool view. it will crash the application.

Description of Change

removed src="about:blank" from contents.setDevToolsWebContents(devToolsWebContents) example

Checklist

Release Notes

Notes:

with src="about:blank" in webview for devtool view. it will crash the application.
@welcome
Copy link

welcome bot commented Feb 20, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 20, 2021
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@errorr404 which version of Electron are you seeing this in? I just tested this on Electron v13.0.0-nightly.20210208 and it works correctly as documented. In fact if I run it with your change, it no longer works.

@errorr404
Copy link
Author

errorr404 commented Feb 22, 2021

@errorr404 which version of Electron are you seeing this in? I just tested this on Electron v13.0.0-nightly.20210208 and it works correctly as documented. In fact if I run it with your change, it no longer works.

@jkleinsc i am using Electron v8.5.5, i am using a webview for showing devtool content, by using src="about:blank" on the webview i got application crash, it is working fine without src="about:blank" for me on Electron v8.5.5.

steps to reproduce:-

@jkleinsc
Copy link
Contributor

@errorr404 ok I see what has happened. For 8-x-y, the documentation is already as you have modified it: https://github.com/electron/electron/blob/v8.5.5/docs/api/web-contents.md#contentssetdevtoolswebcontentsdevtoolswebcontents.
However this documentation was intentionally changed for 9-x-y: #20986. As our documentation always reflects what is in master, the documentation is correct as is, so I am going to close this PR.

@jkleinsc jkleinsc closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants