fix: ensure child window transparency works #28054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows opened via window.open and intecepted via setWindowOpenHandler or the `new-window` event should (a) have the correct background color and (b) that background color should be transparent if specified. The changes in api_web_contents fix (a) and the changes in web_contents_preferences fix (b). Notes: Child windows with specified background colors or transpency now work as intended
MarshallOfSound
force-pushed
the
now-you-dont-see-me
branch
from
6210403
to
c48e1e8
Compare
MarshallOfSound
force-pushed
the
now-you-dont-see-me
branch
from
ab7b458
to
942974a
Compare
nornagon
requested changes
Mar 9, 2021
patches/chromium/moves_background_color_setter_of_webview_to_blinks_webprefs_logic.patch
Outdated
Show resolved
Hide resolved
patches/chromium/moves_background_color_setter_of_webview_to_blinks_webprefs_logic.patch
Outdated
Show resolved
Hide resolved
|
Should this also target 13-x-y? |
5 tasks
MarshallOfSound
added
target/13-x-y
semver/patch
nornagon
approved these changes
Mar 10, 2021
|
@VerteDinde has manually backported this PR to "12-x-y", please check out #28107 |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "13-x-y", please check out #28112 |
Closed
3 tasks
|
Any update on 11-x-y? The problem is quite annoying but I don't have the expertise to backport it myself. |
|
/trop run backport-to 11-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "11-x-y" cleanly; |
|
Removing needs-manual-bp/11-x-y since 11.x is security fixes only now. |
3 tasks
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows opened via window.open and intecepted via setWindowOpenHandler or the
new-windowevent should (a) have the correct background color and (b) that background color should be transparent if specified.The changes in api_web_contents fix (a) and the changes in web_contents_preferences fix (b).
Notes: Child windows with specified background colors or transpency now work as intended