fix: capturePage not resolving with hidden windows #28075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
5 tasks
trop
bot
added
12-x-y
backport
codebytere
approved these changes
Mar 9, 2021
zcbenz
changed the title
zcbenz
changed the title
zcbenz
approved these changes
Mar 10, 2021
|
Release Notes Persisted
|
zcbenz
deleted the
trop/12-x-y-bp-fix-capturepage-not-resolving-with-hidden-windows-1615297931968
branch
This was referenced Mar 11, 2021
Closed
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27883
See that PR for details.
Notes: Fixed an issue where
win.capturePage()never called back after callinghide()for a hidden window on some platforms.