fix: recalibrate simpleFullscreen when display metrics change #28150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Mar 12, 2021
|
Compilation errors on Linux needs fix, LGTM otherwise. Thanks! |
|
@deepak1556 should be set to go! |
codebytere
force-pushed
the
update-simple-fs-display-metrics
branch
from
3c466ed
to
fc798ca
Compare
zcbenz
reviewed
Mar 15, 2021
zcbenz
approved these changes
Mar 15, 2021
|
Release Notes Persisted
|
|
I was unable to backport this PR to "12-x-y" cleanly; |
|
I was unable to backport this PR to "11-x-y" cleanly; |
|
I have automatically backported this PR to "13-x-y", please check out #28216 |
mlaurencin
pushed a commit
that referenced
this pull request
Mar 18, 2021
* fix: recalibrate simpleFullscreen when display metrics change * Address review feedback * fix: compilation issues * Address feedback from review
|
@codebytere has manually backported this PR to "12-x-y", please check out #28869 |
|
@codebytere has manually backported this PR to "11-x-y", please check out #28870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #15494.
Overrides
OnDisplayMetricsChangedinNativeWindowMacso that when display metrics change and theBrowserWindowis insimpleFullscreenmode, the frame is recalibrated for the new bounds.Tested with https://gist.github.com/bpasero/e4013ea83033a8c231f58f94c0df57c3.
cc @bpasero
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where windows in
simpleFullscreenmode were not properly resizing when display metrics changed.