fix: escape URL passed to shell.openExternal on windows #28341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
trop
bot
added
12-x-y
backport
electron-cation
bot
added
new-pr 🌱
codebytere
approved these changes
Mar 23, 2021
|
Release Notes Persisted
|
trop
bot
deleted the
trop/12-x-y-bp-fix-escape-url-passed-to-shell-openexternal-on-windows-1616456024987
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28334
See that PR for details.
Notes: URLS passed to
shell.openExternalon windows are now correctly URI encoded. This was already occurring on macOS and Linux.