Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase corner radius for vibrancy view on big sur #28655

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

robin-fowler
Copy link
Contributor

@robin-fowler robin-fowler commented Apr 14, 2021

Description of Change

Fix #27061 Fix #27080

Checklist

Release Notes

Notes: Fixed corner radius for vibrancy view in macOS 11

@welcome
Copy link

welcome bot commented Apr 14, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 14, 2021
@codebytere codebytere added Big Sur 🍎 semver/patch backwards-compatible bug fixes labels Apr 14, 2021
shell/browser/native_window_mac.mm Outdated Show resolved Hide resolved
shell/browser/native_window_mac.mm Show resolved Hide resolved
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codebytere
Copy link
Member

codebytere commented Apr 14, 2021

@robin-fowler lint is still failing:

} else {
-        radius = 5.0f; // smaller corner radius on older versions
+        radius = 5.0f;  // smaller corner radius on older versions
}

but once that's done this is good to go!

ELECTRON_VERSION Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
shell/browser/native_window_mac.mm Outdated Show resolved Hide resolved
shell/browser/resources/win/electron.rc Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 15, 2021
@KishanBagaria
Copy link
Contributor

Can this be backported to 11.x as well? We're not upgrading to Electron 12 atm because it adds ~1000ms to app launch time.

@MarshallOfSound
Copy link
Member

@KishanBagaria Do you have a bug open with a repro for -->

We're not upgrading to Electron 12 atm because it adds ~1000ms to app launch time.

@MarshallOfSound MarshallOfSound merged commit e12128b into electron:master Apr 15, 2021
@welcome
Copy link

welcome bot commented Apr 15, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Apr 15, 2021

Release Notes Persisted

Fixed corner radius for vibrancy view in macOS 11

@trop
Copy link
Contributor

trop bot commented Apr 15, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 15, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 15, 2021

I have automatically backported this PR to "13-x-y", please check out #28679

@trop trop bot removed the target/13-x-y label Apr 15, 2021
@KishanBagaria
Copy link
Contributor

KishanBagaria commented Apr 15, 2021

@KishanBagaria Do you have a bug open with a repro for -->

We're not upgrading to Electron 12 atm because it adds ~1000ms to app launch time.

Will post issue once I've the repro steps isolated

Edit: posted #28683

@trop
Copy link
Contributor

trop bot commented May 9, 2021

@shatyuka has manually backported this PR to "12-x-y", please check out #29071

@trop
Copy link
Contributor

trop bot commented May 9, 2021

@shatyuka has manually backported this PR to "11-x-y", please check out #29072

@itsnwa
Copy link

itsnwa commented Aug 13, 2021

This seems to be broken after screensaver and screen changes.

This is the window right after launching the app:
CleanShot 2021-08-13 at 12 45 11@2x

Then after I turned my external monitor off and on again:
CleanShot 2021-08-13 at 12 48 54@2x

@tessro
Copy link

tessro commented Aug 31, 2021

We are also seeing this, on Electron 13.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Big Sur 🍎 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Big Sur] window corners are not rounded when using vibrancy effects [Big Sur] Transpearent Window Corners
6 participants