-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase corner radius for vibrancy view on big sur #28655
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@robin-fowler lint is still failing:
but once that's done this is good to go! |
Can this be backported to 11.x as well? We're not upgrading to Electron 12 atm because it adds ~1000ms to app launch time. |
@KishanBagaria Do you have a bug open with a repro for -->
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I was unable to backport this PR to "11-x-y" cleanly; |
I was unable to backport this PR to "12-x-y" cleanly; |
I have automatically backported this PR to "13-x-y", please check out #28679 |
Will post issue once I've the repro steps isolated Edit: posted #28683 |
We are also seeing this, on Electron 13.2.3. |
Description of Change
Fix #27061 Fix #27080
Checklist
npm test
passesRelease Notes
Notes: Fixed corner radius for vibrancy view in macOS 11