Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shell.trashItem crash when called in renderer #28748

Merged
merged 3 commits into from
Apr 22, 2021
Merged

fix: shell.trashItem crash when called in renderer #28748

merged 3 commits into from
Apr 22, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 20, 2021 •
edited

Description of Change

Fixes #28029. This has been broken in the renderer since it was introduced (by me 馃槼 ) in #25114.

Checklist

Release Notes

Notes: Fixed a crash when calling shell.trashItem() from the renderer process.

@electron-cation electron-cation bot added the new-pr 馃尡 PR opened in the last 24 hours label Apr 20, 2021
@nornagon nornagon added the semver/patch backwards-compatible bug fixes label Apr 20, 2021
jkleinsc
jkleinsc previously requested changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like newly added test is failing on all Windows platforms.

nornagon
nornagon commented Apr 21, 2021
View reviewed changes
spec-main/api-shell-spec.ts Outdated Show resolved Hide resolved
@nornagon nornagon requested a review from jkleinsc April 21, 2021 17:37
@electron-cation electron-cation bot removed the new-pr 馃尡 PR opened in the last 24 hours label Apr 21, 2021
@nornagon nornagon merged commit be3c2fd into master Apr 22, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2021

Release Notes Persisted

Fixed a crash when calling shell.trashItem() from the renderer process.

@nornagon nornagon deleted the fix-trashitem-in-renderer branch April 22, 2021 20:46
This was referenced Apr 22, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2021

I have automatically backported this PR to "12-x-y", please check out #28787

@trop
Copy link
Contributor

trop bot commented Apr 22, 2021

I have automatically backported this PR to "13-x-y", please check out #28788

@zcbenz
Copy link
Member

zcbenz commented Apr 26, 2021

@nornagon The newly added test seems to fail consistently on ia32 Windows.

@deepak1556 deepak1556 mentioned this pull request Apr 26, 2021
Merged
@nornagon
Copy link
Member Author

@zcbenz thanks for the ping. I have no idea why this test would fail on ia32 windows but not x64 windows, so for now I'm just going to disable the test to unbreak master.

@nornagon nornagon mentioned this pull request Apr 27, 2021
Merged
@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
@dscalzi dscalzi mentioned this pull request Jun 12, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shell.trashItem crashes the process
4 participants
@nornagon @zcbenz @jkleinsc @codebytere