New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drag region BrowserView calculations on macOS #28984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic in the PR description makes sense and the PR looks fine, but I wish there was a way to write tests for this.
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #29017 |
I have automatically backported this PR to "11-x-y", please check out #29018 |
I have automatically backported this PR to "12-x-y", please check out #29019 |
Description of Change
Closes #28405. This was originally added in #27147, but it turns out that solution masked a different root problem, which was what I later solved in #28268. However, this meant that the previous PR was relying on incorrect assumptions, and would thus offset the bounds too far. This correct it so that all offsetting is handled in a single place for BrowserViews and we can once more safely assume that defaulting to
0, 0
forx, y
in the case of no drag regions will produce the desired drag configuration.Tested with:
cc @Kilian
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where drag regions on macOS would be offset incorrectly when no drag regions were set,