chore: cherry-pick 7abc7e45b2 from node #29021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would appreciate if it could get backported into 12-x-y branch. |
deepak1556
approved these changes
May 6, 2021
|
Wow, thanks for quick LGTM @deepak1556 What's the procedure here? Do we need more LGTMs, or is this PR good to merge already? |
|
Yup a PR needs atleast 2 LGTM before landing, usually a 24hr period should suffice to cover that. This should be good to merge tomorrow. |
zcbenz
approved these changes
May 6, 2021
|
Failing test is unrelated, merging. |
|
Release Notes Persisted
|
This was referenced May 6, 2021
|
I have automatically backported this PR to "12-x-y", please check out #29047 |
|
I have automatically backported this PR to "13-x-y", please check out #29048 |
|
Yay, awesome! Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backports: nodejs/node#38506
See: #28957 for discussion
In few words,
napi_threadsafe_functionwas significantly slower in Electron due to scheduling each call on the next uv tick. We've patched electron in #28957 to let microtasks queue execute from withinuv_run()and now this backports a patch that makesnapi_threadsafe_functioncalls scheduled while one was running happen on the same tick. Fixing the performance issue.cc @codebytere @deepak1556 @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Improved performance of
napi_threadsafe_function