fix: remove background color hack in vibrancy #29114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-vibrancy-titlebar
branch
from
8468fc8
to
70f25d2
Compare
codebytere
approved these changes
May 12, 2021
|
Release Notes Persisted
|
|
I have automatically backported this PR to "13-x-y", please check out #29165 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For Electron <= 12, using vibrancy with titleBarStyle together requires a small hack added by #11886 and #12157, because titleBarStyle was implemented by force showing original titlebar buttons.
But after #27489, the implementation of titleBarStyle no longer uses original titlebar buttons, and the old hack can be removed, which will fix #28782.
Checklist
npm testpassesRelease Notes
Notes: Fix using vibrancy with titleBarStyle together resulting in weird window shadow on macOS.