Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not return value from Menu.setApplicationMenu #29118

Merged
merged 1 commit into from
May 12, 2021

Conversation

tabishmahfuz1
Copy link
Contributor

@tabishmahfuz1 tabishmahfuz1 commented May 12, 2021

Description of Change

Closes #29088.

Fixed an issue where the void function Menu.setApplicationMenu would return a value on some platforms.

Checklist

Release Notes

Notes: Fixed an issue where the void function Menu.setApplicationMenu would return a value on some platforms.

@welcome
Copy link

welcome bot commented May 12, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 12, 2021
@codebytere codebytere changed the title fix: Menu.setApplicationMenu can return a useless array 29088 fix: do not return value from Menu.setApplicationMenu May 12, 2021
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/12-x-y labels May 12, 2021
@MarshallOfSound MarshallOfSound merged commit 5ceec91 into electron:master May 12, 2021
@welcome
Copy link

welcome bot commented May 12, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented May 12, 2021

Release Notes Persisted

Fixed an issue where the void function Menu.setApplicationMenu would return a value on some platforms.

@trop
Copy link
Contributor

trop bot commented May 12, 2021

I have automatically backported this PR to "12-x-y", please check out #29128

@trop
Copy link
Contributor

trop bot commented May 12, 2021

I have automatically backported this PR to "13-x-y", please check out #29129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Menu.setApplicationMenu can return a useless array
4 participants