chore: drop thread_capabilities.patch #29135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
|
cc @zcbenz, do you have thoughts about if this is now safe to remove? |
zcbenz
reviewed
May 18, 2021
There was a problem hiding this comment.
I think #3666 (comment) is still relevant, without this patch the renderer process will not be able to access some resources even when the user has enough permissions.
From security perspective it is probably better removing this patch, but certain users will not be able to run Electron apps and it would be hard for them to find out why.
|
Hm, looking into it more, it seems this is only called when launching child processes via the zygote. We only do this for sandboxed processes since #15870. So I think we no longer need this. |
deepak1556
approved these changes
May 18, 2021
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I think this might be limiting our sandboxing on linux.
WIP until I read through #3666 to understand if this will cause issues. That
issue ends with "we are not using sandboxing at all" which is now far from
true, so I'd like to find a way to reenable this for sandboxed processes at
least.
Checklist
Release Notes
Notes: none