Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: illegal access errors with nodeIntegrationInSubFrames #29170

Merged
merged 4 commits into from
May 14, 2021
Merged

fix: illegal access errors with nodeIntegrationInSubFrames #29170

merged 4 commits into from
May 14, 2021

Commits on May 14, 2021

  1. fix: illegal access errors with nodeIntegrationInSubFrames

    @codebytere @electron-bot
    codebytere authored and electron-bot committed May 14, 2021
    Configuration menu
    Copy the full SHA
    a028797 View commit details
    Browse the repository at this point in the history

  2. test: fixup on windows

    @codebytere @electron-bot
    codebytere authored and electron-bot committed May 14, 2021
    Configuration menu
    Copy the full SHA
    e7dd580 View commit details
    Browse the repository at this point in the history

  3. Address feedback from review

    @codebytere @electron-bot
    codebytere authored and electron-bot committed May 14, 2021
    Configuration menu
    Copy the full SHA
    85195e4 View commit details
    Browse the repository at this point in the history

  4. Update shell/renderer/electron_render_frame_observer.cc 

    Co-authored-by: Robo <hop2deep@gmail.com>
    @codebytere @deepak1556 @electron-bot
    2 people authored and electron-bot committed May 14, 2021
    Configuration menu
    Copy the full SHA
    cee0317 View commit details
    Browse the repository at this point in the history