fix: Alt+Click should not toggle menu bar #29318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-menu-bar-quirks
branch
from
7865dcc
to
fd3a1fb
Compare
codebytere
approved these changes
May 31, 2021
|
Release Notes Persisted
|
This was referenced Jun 1, 2021
|
I have automatically backported this PR to "13-x-y", please check out #29450 |
|
I have automatically backported this PR to "12-x-y", please check out #29451 |
|
I have automatically backported this PR to "14-x-y", please check out #29452 |
|
This (un?)broke Electron preventing a "save as" dialog when alt + clicking on a URL. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Holding Alt + mouse click should not result in the menu bar getting toggled, close #26154.
Release Notes
Notes: Fix pressing Alt with mouse click results in toggling menu bar.