Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable default async spellchecker on Windows #29706

Merged
merged 3 commits into from
Jun 15, 2021
Merged

chore: disable default async spellchecker on Windows #29706

merged 3 commits into from
Jun 15, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 15, 2021

Backport of #29690

See that PR for details.

Notes: Fixed a feature flag issue where spellchecker methods returned empty suggestion lists on Windows.

@trop trop bot requested a review from a team as a code owner June 15, 2021 16:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2021
@trop trop bot requested a review from VerteDinde June 15, 2021 16:12
@trop trop bot mentioned this pull request Jun 15, 2021
Merged
5 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2021
VerteDinde
VerteDinde requested changes Jun 15, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like two patches were also pulled in by this backport, will fix that before merging

@VerteDinde VerteDinde merged commit 2ef55e1 into 13-x-y Jun 15, 2021
@VerteDinde VerteDinde deleted the trop/13-x-y-bp-chore-disable-default-async-spellchecker-on-windows-1623773523524 branch June 15, 2021 19:49
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2021

Release Notes Persisted

Fixed a feature flag issue where spellchecker methods returned empty suggestion lists on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @VerteDinde