New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: media key globalShortcuts on macOS #30552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like newly added test is failing on some platforms.
ec4e610
to
6ad6307
Compare
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #30568 |
I have automatically backported this PR to "14-x-y", please check out #30569 |
I have automatically backported this PR to "15-x-y", please check out #30570 |
Description of Change
Closes #30543.
Refs #27475.
This CL moved around the location for media key listener logic in Chromium, and as a result this patch was fully removed instead of being updated (regressing #21959).
This fixes the issue by reinvigorating the patch in accordance with latest upstream logic.
Checklist
npm test
passesRelease Notes
Notes: Fixed media key
globalShortcut
s on macOS.