Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added ability to configure if window should close when opener closes #31314

Merged
merged 9 commits into from Feb 23, 2022
Merged

feat: Added ability to configure if window should close when opener closes #31314

merged 9 commits into from Feb 23, 2022

Commits on Jan 25, 2022

  1. feat: Added ability to configure if window should close when opener c… 

    …loses
    @t57ser
    t57ser committed Jan 25, 2022
    Copy the full SHA
    59ebde4 View commit details
    Browse the repository at this point in the history

  2. fix: check if embedder is destroyed

    @t57ser
    t57ser committed Jan 25, 2022
    Copy the full SHA
    b4913df View commit details
    Browse the repository at this point in the history

  3. fix: correctly take over closeWithOpener property

    @t57ser
    t57ser committed Jan 25, 2022
    Copy the full SHA
    2fbadf6 View commit details
    Browse the repository at this point in the history

  4. chore: Added documentation

    @t57ser
    t57ser committed Jan 25, 2022
    Copy the full SHA
    2de6d70 View commit details
    Browse the repository at this point in the history

  5. Update docs/api/window-open.md 

    Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
    @t57ser
    t57ser and John Kleinschmidt committed Jan 25, 2022
    Copy the full SHA
    d73176f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. chore: refactor 

    Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
    @t57ser @nornagon
    t57ser and nornagon committed Jan 26, 2022
    Copy the full SHA
    fc21022 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. chore: changed property name from closeWithOpener to outlivesOpener

    @t57ser
    t57ser committed Jan 27, 2022
    Copy the full SHA
    f2cd096 View commit details
    Browse the repository at this point in the history

  2. dummy change to kick lint

    @nornagon
    nornagon committed Jan 27, 2022
    Copy the full SHA
    3a1ae0a View commit details
    Browse the repository at this point in the history

  3. undo above

    @nornagon
    nornagon committed Jan 27, 2022
    Copy the full SHA
    261e1b0 View commit details
    Browse the repository at this point in the history