fix: second-instance additionalData parameter #31661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Looks like arrays don't get passed properly on macOS and Linux. Will look more into it later. |
rzhao271
changed the title
deepak1556
approved these changes
Nov 3, 2021
zcbenz
approved these changes
Nov 4, 2021
|
Failing tests are unrelated, merging. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "16-x-y", please check out #31708 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
* test: second-instance additionalData parameter * Fix posix implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds more tests to the
app.requestSingleInstanceLocksecond instance -> first instance data flow, since it'll be helpful to have tests running more for that flow before part ii (#31460) gets merged in.CC @deepak1556
Checklist
npm testpasses (the other test failures on CI seem unrelated).Release Notes
Notes: Fixed behaviour on posix when passing lists into
app.requestSingleInstanceLock(additionalData)API.