New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BrowserView setBackgroundColor needs two calls #31863
Conversation
Release Notes Persisted
|
I was unable to backport this PR to "13-x-y" cleanly; |
I have automatically backported this PR to "14-x-y", please check out #31945 |
I have automatically backported this PR to "15-x-y", please check out #31946 |
I have automatically backported this PR to "16-x-y", please check out #31947 |
I have automatically backported this PR to "17-x-y", please check out #31948 |
@VerteDinde has manually backported this PR to "13-x-y", please check out #32704 |
Description of Change
I determined in testing that #31746 regressed #29778.
It remains the case that we want to call
SetPageBaseBackgroundColor
on theBrowserView
's webContents, but we don't want to do this at the expense of callingSetBackgroundColor
on theRenderWidgetHostView
. We need to do both calls - similar to what's done here:electron/shell/browser/api/electron_api_web_contents.cc
Lines 1462 to 1463 in 7e328c4
Tested with
Checklist
npm test
passesRelease Notes
Notes: Fixed a potential issue when setting backgroundColor on
BrowserView
s.