Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BrowserView setBackgroundColor needs two calls #31863

Merged
merged 1 commit into from Nov 22, 2021

Conversation

codebytere
Copy link
Member

Description of Change

I determined in testing that #31746 regressed #29778.

It remains the case that we want to call SetPageBaseBackgroundColor on the BrowserView's webContents, but we don't want to do this at the expense of calling SetBackgroundColor on the RenderWidgetHostView. We need to do both calls - similar to what's done here:

web_contents()->SetPageBaseBackgroundColor(color);
rwhv->SetBackgroundColor(color.value_or(SK_ColorWHITE));

Tested with

Checklist

Release Notes

Notes: Fixed a potential issue when setting backgroundColor on BrowserViews.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Nov 16, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 16, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 17, 2021
@zcbenz zcbenz merged commit 239ba7d into main Nov 22, 2021
@zcbenz zcbenz deleted the bv-bg-color-view-and-wc branch November 22, 2021 00:38
@release-clerk
Copy link

release-clerk bot commented Nov 22, 2021

Release Notes Persisted

Fixed a potential issue when setting backgroundColor on BrowserViews.

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "14-x-y", please check out #31945

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "15-x-y", please check out #31946

@trop trop bot removed target/14-x-y labels Nov 22, 2021
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "16-x-y", please check out #31947

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "17-x-y", please check out #31948

@trop
Copy link
Contributor

trop bot commented Feb 1, 2022

@VerteDinde has manually backported this PR to "13-x-y", please check out #32704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants