fix: Don't create console window when creating process #32340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
force-pushed
the
rzhao271/revert-console
branch
from
bed7a42
to
72b7027
Compare
deepak1556
requested changes
Jan 5, 2022
There was a problem hiding this comment.
This patch was removed to adopt the embedder flag provided in nodejs/node#39712
It looks like the spawn_sync path was missed in the upstream PR. This should be addressed there.
/cc @zcbenz
rzhao271
force-pushed
the
rzhao271/revert-console
branch
2 times, most recently
from
a61327d
to
a94acd3
Compare
rzhao271
force-pushed
the
rzhao271/revert-console
branch
from
a94acd3
to
52a6b9e
Compare
deepak1556
reviewed
Jan 5, 2022
patches/node/fix_don_t_create_console_window_when_creating_process.patch
Show resolved
Hide resolved
|
The upstream node patch is being tracked at nodejs/node#41412 and seems nearly ready to merge. |
deepak1556
reviewed
Jan 6, 2022
patches/node/fix_don_t_create_console_window_when_creating_process.patch
Outdated
Show resolved
Hide resolved
…cess.patch Co-authored-by: Robo <hop2deep@gmail.com>
deepak1556
approved these changes
Jan 6, 2022
zcbenz
approved these changes
Jan 7, 2022
|
Release Notes Persisted
|
This was referenced Jan 7, 2022
|
I have automatically backported this PR to "17-x-y", please check out #32378 |
|
I have automatically backported this PR to "16-x-y", please check out #32379 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
* fix: Don't create console window when creating process * Update patches/node/fix_don_t_create_console_window_when_creating_process.patch Co-authored-by: Robo <hop2deep@gmail.com> * Remove extra line in description Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Since the
windowsHideparameters still default tofalse, we need to keep the patch that disables console windows from showing up. Otherwise, forexecSynccalls, orspawnSynccalls withshell: true, console windows still show up for Windows users.This issue has been occurring since Electron 16.
Downstream issue: microsoft/vscode#138792
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Fix regression where console windows would open for execSync and some spawnSync calls for Windows users.