Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undisable AXTextMarker and related APIs on MAS #32543

Merged
merged 1 commit into from Jan 20, 2022
Merged

fix: undisable AXTextMarker and related APIs on MAS #32543

merged 1 commit into from Jan 20, 2022

Conversation

nornagon
Copy link
Member

Description of Change

This re-enables usage of AXTextMarker and related APIs, given that these are
now public as of macOS 12.0. It is hoped that these symbols are now allowed
through the MAS review process, given that they are public APIs.

Checklist

Release Notes

Notes: Fixed VoiceOver not reading typed words correctly in MAS builds.

@nornagon nornagon requested a review from a team as a code owner January 19, 2022 22:10
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/17-x-y labels Jan 19, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 19, 2022
clavin
clavin approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@clavin clavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 Hoping that this passes the MAS check

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 20, 2022
@nornagon nornagon merged commit 87b3f6d into main Jan 20, 2022
@nornagon nornagon deleted the undisable-axtextmarker branch January 20, 2022 23:42
@release-clerk
Copy link

release-clerk bot commented Jan 20, 2022

Release Notes Persisted

Fixed VoiceOver not reading typed words correctly in MAS builds.

@trop
Copy link
Contributor

trop bot commented Jan 20, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@nornagon nornagon mentioned this pull request Jan 20, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 20, 2022

@nornagon has manually backported this PR to "17-x-y", please check out #32567

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@nornagon @t57ser
fix: undisable AXTextMarker and related APIs on MAS (electron#32543)
e9ad75e
@commit-lint commit-lint bot mentioned this pull request Mar 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@clavin clavin clavin approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @codebytere @clavin