fix: bundle a11y strings in resources #32564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jan 20, 2022
codebytere
approved these changes
Jan 20, 2022
VerteDinde
force-pushed
the
ax-strings
branch
from
721388c
to
5cd26ed
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "17-x-y", please check out #32578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add strings that were missing in resource pak bundles, resulting in crashes
when starting VoiceOver on macOS (and probably other problems, too).
These were split out in
https://chromium-review.googlesource.com/c/chromium/src/+/3323855, but we
didn't notice straight away.
Checklist
Release Notes
Notes: Fixed a crash when starting VoiceOver on macOS.