New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transparent window max/unmax event firing #32643
Conversation
Thanks for jumping on fixing this. 😄 Couple small things:
|
The Linux CI build is having issues, but I've checked out and built this branch on Ubuntu 20.04 and confirmed the new tests work there (with the changes from #32575 to re-enable event tests), after one small change I've suggested above. |
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #32688 |
I have automatically backported this PR to "16-x-y", please check out #32689 |
I have automatically backported this PR to "17-x-y", please check out #32690 |
Description of Change
Closes #32633.
This PR fixes an issue with transparent windows failing to fire the
maximize
andunmaximize
events on Windows.We've made a few fixes to transparent window size events on Windows of late, including #28207 and #26586. As of now, we set transparent window to maximized by calling
SetBounds
, which means thatNativeWindowViews::HandleSizeEvent
is not triggered withSIZE_MAXIMIZED
as it should be. This also presents an issue with unmaximization for similar reasons, and caused themaximize
andunmaximize
events not to fire on Windows. We can fix this issue by callingNotifyWindowMaximize()
andNotifyWindowUnmaximize()
in the transparency-specific logic blocks ofMaximize()
andUnmaximize()
.cc @dsanders11
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue with transparent windows failing to fire the
maximize
andunmaximize
events on Windows.