Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump @types/node to v16 #32729

Closed
wants to merge 1 commit into from

Conversation

bavulapati
Copy link
Contributor

Description of Change

Bump @types/node to major line v16 as we are already using node v16.x.x

Re-enabling the associated test as the require PR got merged
cc: @codebytere @MarshallOfSound @dsanders11

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@bavulapati bavulapati requested a review from a team as a code owner February 3, 2022 15:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@bavulapati
Copy link
Contributor Author

The test failure looks unrelated to the change.

@dsanders11
Copy link
Member

Confirming the one build failure is unrelated.

not ok 18 app module app.requestSingleInstanceLock gets back an ack after preventing default
  AssertionError: received data null is not equal to expected data {"level":1,"testkey":"acktestvalue1","inner":{"level":2,"testkey":"acktestvalue2"}}.: expected null to deeply equal { level: 1,
    testkey: 'acktestvalue1',
    inner: { level: 2, testkey: 'acktestvalue2' } }
      at testArgumentPassing (electron\spec-main\api-app-spec.ts:269:42)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (electron\spec-main\api-app-spec.ts:308:7)

@bavulapati, I think this should also bump the version in the root package.json at the same time, so they stay in sync?

@codebytere
Copy link
Member

@bavulapati lint failure:

../node_modules/@types/express-serve-static-core/index.d.ts(505,18): error TS2430: Interface 'Response' incorrectly extends interface 'ServerResponse'.
Property 'req' is optional in type 'Response' but required in type 'ServerResponse'.

@bavulapati
Copy link
Contributor Author

@codebytere I've addressed the lint errors. Had to update few more types.
@dsanders11 Updated the node types in the root package.json as well.
Waiting for the CI to go all ✅

@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants