Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pointer lock escape handling #32827

Closed
wants to merge 3 commits into from
Closed

fix: pointer lock escape handling #32827

wants to merge 3 commits into from

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 9, 2022

Backport of #32369

See that PR for details.

Notes: Fixed an issue where Pointer Lock behavior could not be properly exited.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2022
@trop trop bot requested a review from codebytere February 9, 2022 09:41
@trop trop bot mentioned this pull request Feb 9, 2022
Merged
3 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 9, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2022
zcbenz
zcbenz requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark as request changes since there is test failing.

@miniak miniak force-pushed the trop/17-x-y-bp-fix-pointer-lock-escape-handling-1644399690402 branch from a98f989 to f498d0a Compare March 30, 2022 20:11
@codebytere codebytere requested a review from zcbenz April 4, 2022 09:37
@miniak
Copy link
Contributor

miniak commented Apr 4, 2022 •
edited

@codebytere the tests on Mac are still failing

@miniak miniak closed this Aug 3, 2022
@miniak miniak deleted the trop/17-x-y-bp-fix-pointer-lock-escape-handling-1644399690402 branch August 3, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @codebytere