Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't restore maximized BrowserWindow when calling showInactive #32870

Merged
merged 1 commit into from Feb 21, 2022
Merged

fix: don't restore maximized BrowserWindow when calling showInactive #32870

merged 1 commit into from Feb 21, 2022

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Feb 12, 2022 •
edited

Description of Change

Fixes #32373.

Checklist

Release Notes

Notes: Fixed BrowserWindow.showInactive restoring a maximized window to non-maximized on Windows

@dsanders11 dsanders11 requested a review from a team as a code owner February 12, 2022 02:07
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 12, 2022
@dsanders11 dsanders11 marked this pull request as draft February 12, 2022 02:10
@dsanders11 dsanders11 force-pushed the cherry-pick/main/chromium/a69b99519f91 branch from 8fc319e to e60948c Compare February 14, 2022 22:40
@dsanders11 dsanders11 changed the title chore: cherry-pick a69b99519f91 from chromium fix: don't restore maximized BrowserWindow when calling ShowInactive Feb 14, 2022
@dsanders11 dsanders11 changed the title fix: don't restore maximized BrowserWindow when calling ShowInactive fix: don't restore maximized BrowserWindow when calling showInactive Feb 14, 2022
@dsanders11 dsanders11 force-pushed the cherry-pick/main/chromium/a69b99519f91 branch 3 times, most recently from 5eefaad to a8395d0 Compare February 15, 2022 07:39
@dsanders11 dsanders11 force-pushed the cherry-pick/main/chromium/a69b99519f91 branch from a8395d0 to 8e1fcc0 Compare February 16, 2022 04:40
@dsanders11 dsanders11 marked this pull request as ready for review February 17, 2022 06:01
@dsanders11
Copy link
Member Author

Ready for review now. Unfortunately had to hack up the test a bit because of various issues. Events for Linux still don't play nice with CI, see #32575. For the macOS maximize issue, see #32947.

@codebytere codebytere added target/17-x-y semver/patch backwards-compatible bug fixes labels Feb 17, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2022
@codebytere codebytere merged commit 069cde0 into electron:main Feb 21, 2022
@release-clerk
Copy link

release-clerk bot commented Feb 21, 2022

Release Notes Persisted

Fixed BrowserWindow.showInactive restoring a maximized window to non-maximized on Windows

This was referenced Feb 21, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "16-x-y", please check out #33020

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "17-x-y", please check out #33021

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "18-x-y", please check out #33022

@dsanders11 dsanders11 deleted the cherry-pick/main/chromium/a69b99519f91 branch March 14, 2022 02:54
@commit-lint commit-lint bot mentioned this pull request Apr 13, 2022
Open
bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@dsanders11 @bavulapati
fix: don't restore maximized BrowserWindow when calling showInactive (e…
e7fe3a7 
…lectron#32870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserWindow.showInactive Will Restore Maximized Window
2 participants
@dsanders11 @codebytere