Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webContents.openDevTools({mode}) not working #32946

Merged
merged 1 commit into from Feb 21, 2022
Merged

fix: webContents.openDevTools({mode}) not working #32946

merged 1 commit into from Feb 21, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 17, 2022

Backport of #32829

See that PR for details.

Notes: Fixed an issue where webContents.openDevTools({ mode }) did not work for certain dock positions.

@trop trop bot requested a review from a team as a code owner February 17, 2022 05:59
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2022
@trop trop bot requested a review from codebytere February 17, 2022 05:59
@trop trop bot mentioned this pull request Feb 17, 2022
Merged
3 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 17, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2022
@codebytere
Copy link
Member

node feature does not hang when using the fs module in the renderer process

is known and unrelated.

@codebytere codebytere merged commit d07fe44 into 18-x-y Feb 21, 2022
@codebytere codebytere deleted the trop/18-x-y-bp-fix-webcontents-opendevtools-mode-not-working-1645077574768 branch February 21, 2022 09:25
@release-clerk
Copy link

release-clerk bot commented Feb 21, 2022

Release Notes Persisted

Fixed an issue where webContents.openDevTools({ mode }) did not work for certain dock positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere