fix: macOS tray icon alternate images #33026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
reviewed
Feb 23, 2022
patches/chromium/fix_don_t_restore_maximized_windows_when_calling_showinactive.patch
Outdated
Show resolved
Hide resolved
codebytere
force-pushed
the
fix-pressed-image
branch
from
4749362
to
a68ec28
Compare
codebytere
force-pushed
the
fix-pressed-image
branch
2 times, most recently
from
a68ec28
to
9f14c40
Compare
zcbenz
approved these changes
Feb 23, 2022
|
hi, haven't merged into the main branch yet? |
codebytere
force-pushed
the
fix-pressed-image
branch
from
9f14c40
to
2e573a4
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "15-x-y", please check out #33104 |
This was referenced Feb 28, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33105 |
|
I have automatically backported this PR to "16-x-y", please check out #33106 |
|
I have automatically backported this PR to "18-x-y", please check out #33107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33008.
Fixes an issue where
alternateImages did not work properly on macOS. To fix this, we need to change the button type when setting an alternate image because the default button type forNSStatusItem,NSStatusBarButton, does not display alternate content when clicked.NSButtonTypeMomentaryChangedisplays its alternate content when clicked and returns to its normal content when the user releases it, which is the behavior users would expect when clicking a button with an alternate image set. After this fix, the tray icon displays the same behavior as it did prior to this breaking. Also tested with context menus etc to ensure nothing else broke by changing this.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where
alternateImages did not work properly on macOS.