-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport dd4c3ddadbb9 from chromium #33038
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Can somebody please test it on gnome and kde. It work perfect under sway but after downgrading I noticed that it doesn't work with wlroots 0.14 because it passes a read-write file descriptor (which is technically not an issue but makes an assertion fail). The spec says the file descriptor should be mapped with MAP_PRIVATE which would need bigger adjustments. |
Now it should no longer cause any regressions. Now I manually mmap the file descriptor and munmap it afterwards. This approach is inspired by code I found in Chromium 96. |
Apply PR electron/electron#33038 (fixes FS#74109). git-svn-id: file:///srv/repos/svn-community/svn@1153075 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Apply PR electron/electron#33038 (fixes FS#74109). git-svn-id: file:///srv/repos/svn-community/svn@1153075 9fca08f4-af9d-4005-b8df-a31f2cc04f65
No Release Notes |
Chromium tries to bind to the newest version of some wayland interfaces. This causes issues when it doesn't actually support the version.
This patch ensures that only supported versions are bound to.
Fixes #32487
Backport of #32603
Notes: none.