Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WCO height option #33061

Merged
merged 3 commits into from Feb 28, 2022
Merged

feat: add WCO height option #33061

merged 3 commits into from Feb 28, 2022

Commits on Feb 23, 2022

  1. feat: add WCO height option (#31222) 

    * feat: add WCO height option

* add docs and mac functionality

* add macOS functionality and height lowerbound

* Update docs/api/browser-window.md

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* update macOS functionality

* add chromium related notes

* add test and fix pixel under button bug and fix typo

* revert changes to docs/api/frameless-window.md

* modify `useCustomHeight` calls

* update `useCustomHeight` and `getCurrentMargin`

* modify margin calculation

* fix minimum custom height on macOS

* Update window_buttons_proxy.mm

* fix specified traffic light positions

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
    @mlaurencin @jkleinsc
    mlaurencin and jkleinsc committed Feb 23, 2022
    Copy the full SHA
    14df7b3 View commit details
    Browse the repository at this point in the history

  2. Update win_caption_button.h

    @mlaurencin
    mlaurencin committed Feb 23, 2022
    Copy the full SHA
    9c55b14 View commit details
    Browse the repository at this point in the history

  3. Update win_caption_button_container.h

    @mlaurencin
    mlaurencin committed Feb 23, 2022
    Copy the full SHA
    61fbb9a View commit details
    Browse the repository at this point in the history