fix: crash when WindowButtonsProxy references cleared NSWindow #33069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardberger
changed the title
samuelmaddock
approved these changes
Mar 1, 2022
zcbenz
reviewed
Mar 2, 2022
zcbenz
approved these changes
Mar 8, 2022
jkleinsc
requested changes
Mar 22, 2022
There was a problem hiding this comment.
@gerhardberger can you rebase your PR on the latest from main? I believe that will resolve the failing CI/tests.
gerhardberger
force-pushed
the
reset-buttons-proxy-mac
branch
from
2b23684
to
38e45a2
Compare
zcbenz
force-pushed
the
reset-buttons-proxy-mac
branch
from
38e45a2
to
572f259
Compare
jkleinsc
approved these changes
Mar 29, 2022
|
Release Notes Persisted
|
This was referenced Mar 29, 2022
|
I have automatically backported this PR to "15-x-y", please check out #33487 |
|
I have automatically backported this PR to "17-x-y", please check out #33488 |
|
I have automatically backported this PR to "16-x-y", please check out #33489 |
|
I have automatically backported this PR to "18-x-y", please check out #33490 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…ron#33069) * resets WindowButtonsProxy on window delete on macOS * fixes reset
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…ron#33069) * resets WindowButtonsProxy on window delete on macOS * fixes reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR resets the
WindowButtonsProxyinNativeWindowMacwhen deleting the underlyingNSWindow. This is needed, becauseWindowButtonsProxyhas a reference toNSWindow, which is not cleared whenNSWindowis. This can cause a crash whenWindowButtonsProxycalls something on theNSWindowwhen that is already cleared.We ran into this crash at Around only when we were updating our electron app and wanted to quit the application and restart a new one. So it's hard to formulate a repro for this.
Checklist
Release Notes
Notes: Fix crash when WindowButtonsProxy references cleared NSWindow