Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macOS tray icon alternate images #33104

Merged
merged 1 commit into from Mar 2, 2022
Merged

fix: macOS tray icon alternate images #33104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions shell/browser/ui/tray_icon_cocoa.mm
View file
Open in desktop
Expand Up @@ -93,6 +93,15 @@ - (void)setImage:(NSImage*)image {

- (void)setAlternateImage:(NSImage*)image {
[[statusItem_ button] setAlternateImage:image];

// We need to change the button type here because the default button type for
// NSStatusItem, NSStatusBarButton, does not display alternate content when
// clicked. NSButtonTypeMomentaryChange displays its alternate content when
// clicked and returns to its normal content when the user releases it, which
// is the behavior users would expect when clicking a button with an alternate
// image set.
[[statusItem_ button] setButtonType:NSButtonTypeMomentaryChange];
[self updateDimensions];
}

- (void)setIgnoreDoubleClickEvents:(BOOL)ignore {
Expand Down