Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove redundant color diffing dependency #33215

Merged
merged 1 commit into from Oct 11, 2022
Merged

test: remove redundant color diffing dependency #33215

merged 1 commit into from Oct 11, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Follow up to #31017 - remove dependency added in #32593.

Checklist

Release Notes

Notes: none

jkleinsc
jkleinsc requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the modified tests on mac are either flaky or failing.

@codebytere codebytere requested review from a team as code owners July 21, 2022 08:43
@codebytere codebytere force-pushed the remove-custom-bg-color-spec branch 6 times, most recently from 456a5b9 to cd9decf Compare July 26, 2022 14:43
@codebytere codebytere force-pushed the remove-custom-bg-color-spec branch 2 times, most recently from f78322c to 6eb1fba Compare October 6, 2022 12:08
@jkleinsc jkleinsc merged commit e8ae057 into main Oct 11, 2022
@jkleinsc jkleinsc deleted the remove-custom-bg-color-spec branch October 11, 2022 17:12
@release-clerk
Copy link

release-clerk bot commented Oct 11, 2022

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Feb 6, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
test: remove redundant color diffing dependency (electron#33215)
8fd6bb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak miniak approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @jkleinsc @miniak @samuelmaddock