Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize asar support in worker threads #33216

Merged
merged 6 commits into from Mar 23, 2022
Merged

fix: initialize asar support in worker threads #33216

merged 6 commits into from Mar 23, 2022

Commits on Mar 10, 2022

  1. fix: initialize asar support in worker threads 

    Use `ObjectWrap` instead of gin's Wrap in `electron_api_asar.cc` because
gin isn't fully initialized (and apparently not possible to initialize
without ruining the isolate configuration and array buffer allocator) in
worker threads. In the worker thread call `setupAsarSupport` just as we
do for the main process.
    @indutny
    indutny committed Mar 10, 2022
    Copy the full SHA
    3a05f9c View commit details
    Browse the repository at this point in the history

  2. Update lib/asar/fs-wrapper.ts 

    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    @indutny @RaisinTen
    indutny and RaisinTen committed Mar 10, 2022
    Copy the full SHA
    51aaabc View commit details
    Browse the repository at this point in the history

  3. Update patches/node/worker_thread_add_asar_support.patch 

    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    @indutny @RaisinTen
    indutny and RaisinTen committed Mar 10, 2022
    Copy the full SHA
    897e082 View commit details
    Browse the repository at this point in the history

  4. Add a test

    @indutny @indutny-signal
    indutny authored and indutny-signal committed Mar 10, 2022
    Copy the full SHA
    7ce6f72 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Merge branch 'main' into feature/asar-support-in-worker-threads

    @indutny-signal
    indutny-signal committed Mar 14, 2022
    Copy the full SHA
    49203e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Merge branch 'main' into feature/asar-support-in-worker-threads

    @jkleinsc
    jkleinsc committed Mar 22, 2022
    Copy the full SHA
    b631fcd View commit details
    Browse the repository at this point in the history